search

Financial-Times / splunk-heroku

Support for Heroku log drains packaged as a Splunk app.
https://tech.in.ft.com/tech-topics/logging/splunk/logging-from-heroku
MIT License
2 stars 0 forks source link

Add CONTRIBUTING.md #36

Closed sjparkinson closed 2 years ago

sjparkinson commented 2 years ago

Provide some ideas on how to verify your changes in this project. Until we do have unit tests the GitHub checks are not enough to know that changes are safe to merge.

sjparkinson commented 2 years ago

Bah I accidently checked auto-merge and it didn't even wait for a build!

@mkk19 if you have any feedback on this let me know, I think we've talked through a bunch of this but I'm keen to have it documented for others too.

mkk19 commented 2 years ago

Bah I accidently checked auto-merge and it didn't even wait for a build!

@mkk19 if you have any feedback on this let me know, I think we've talked through a bunch of this but I'm keen to have it documented for others too.

No worries, it looks good to me. We do have a Splunk instance (that Jon setup) in our dev sandbox account that we can also use to deploy Splunk apps as well, not sure if that's worth mentioning as it's only relevant to our team for now.

sjparkinson commented 2 years ago

We do have a Splunk instance (that Jon setup) in our dev sandbox account that we can also use to deploy Splunk apps as well, not sure if that's worth mentioning as it's only relevant to our team for now.

Oh good point, but yeah let's leave it for now as I wouldn't expect us to dish out access to it.