search

Financial-Times / tako

🐙 A GitHub App that provides an API listing the repositories it is installed on.
MIT License
4 stars 0 forks source link

fix(deps): update dependency probot to v9 #123

Closed renovate[bot] closed 5 years ago

renovate[bot] commented 5 years ago

This PR contains the following updates:

Package Type Update Change References
probot dependencies major 8.0.0-beta.4 -> 9.1.1 homepage, source

Release Notes

probot/probot ### [`v9.1.1`](https://togithub.com/probot/probot/releases/v9.1.1) [Compare Source](https://togithub.com/probot/probot/compare/v9.1.0...v9.1.1) ##### Bug Fixes - **package:** update semver to version 6.0.0 ([fd63724](https://togithub.com/probot/probot/commit/fd63724)), closes [#​897](https://togithub.com/probot/probot/issues/897) ### [`v9.1.0`](https://togithub.com/probot/probot/releases/v9.1.0) [Compare Source](https://togithub.com/probot/probot/compare/v9.0.2...v9.1.0) ##### Features - **typescript:** export type OnCallback ([#​896](https://togithub.com/probot/probot/issues/896)) ([036ee3b](https://togithub.com/probot/probot/commit/036ee3b)) ### [`v9.0.2`](https://togithub.com/probot/probot/releases/v9.0.2) [Compare Source](https://togithub.com/probot/probot/compare/v9.0.1...v9.0.2) ##### Bug Fixes - **package:** update [@​octokit/graphql](https://togithub.com/octokit/graphql) to version 2.0.2 ([e584124](https://togithub.com/probot/probot/commit/e584124)) ### [`v9.0.1`](https://togithub.com/probot/probot/releases/v9.0.1) [Compare Source](https://togithub.com/probot/probot/compare/v9.0.0...v9.0.1) ##### Bug Fixes - **package:** update dotenv to version 7.0.0 ([28ead7e](https://togithub.com/probot/probot/commit/28ead7e)) ### [`v9.0.0`](https://togithub.com/probot/probot/releases/v9.0.0) [Compare Source](https://togithub.com/probot/probot/compare/0bef3b910aee2671ee18138738d9d486488b22f4...v9.0.0) ##### Breaking changes - ⚠️ **all [previously deprecated methods](https://togithub.com/octokit/rest.js/releases/tag/v15.18.0#deprecations) have been removed**. Make sure you address all deprecation messages you see with Probot v7 before upgrading. - `context.github.query()`: Changes in errors thrown due to GraphQL errors - `error.name` is now `GraphqlError`, was `GraphQLQueryError` - `error.query` is now `error.request.query` - preview headers that are not required to use an API are no longer set automatically. Set using `{headers: { accept: ''}` - `.gitdata.getTags()` has been removed. Use `.git.listRefs({namespace: tags})` instead - Methods for undocumented endpoints have been removed. - Instead of `octokit.users.getById({id})` use `octokit.request('GET /user/:id', {id})` - Instead of `octokit.repos.getById({id})` use `octokit.request('GET /repositories/:id', {id})` - `octokit.enterprise.*` methods have been removed. Use your own [`@ocotkit/rest`](https://togithub.com/octokit/rest.js) instance and install the [`@octokit/enterprise-rest` plugin](https://togithub.com/octokit/plugin-enterprise-rest.js) - `octokit.issues.addLabels` sends `labels` parameter with "`labels`" namespace instead of sending the array in the request body root. This is not supported by GitHub Enterprise 2.15 or older. You have several options. 1. Use the [`@octokit/enterprise-compatibility` plugin](https://togithub.com/octokit/plugin-enterprise-compatibility.js) 2. Use the [`@octokit/enterprise-rest` plugin](https://togithub.com/octokit/plugin-enterprise-rest.js) loading all routes for the GHE version you want to support 3. Use `octokit.request()` directly: ```js octokit.request('/repos/:owner/:repo/issues/:number/labels', { owner, repo, number, data: ['label1', 'label2'] }) ``` - The `milestone` parameter is no longer validated using a regex as it cannot be derived from [octokit/routes](https://togithub.com/octokit/routes) - `error.status` is now the response status code number. The status text is no longer returned - Deprecated `event.event` property is no longer supported. Use `event.name` instead - Deprecated `new Probot({catchErrors})` has been removed - `probot simulate` hase been removed, use `probot receive` instead ##### Features - Pagination: the [`.paginate` API from @​octokit/rest.js](https://togithub.com/octokit/rest.js/#pagination) is now used - .paginate(options, mapFn) now accepts the request options, just like `ocotkit.request`. - .paginate.iterator(options) allows for async iteration. - Custom requests using [octokit.request & octokit.request.endpoint](https://togithub.com/octokit/rest.js/#custom-requests). - Improved Typescript definitions for `context.github` - add constructor option for redis config ([#​846](https://togithub.com/probot/probot/issues/846)) ([4bbf29c](https://togithub.com/probot/probot/commit/4bbf29c)), closes [#​845](https://togithub.com/probot/probot/issues/845) - Add overloads for all Webhook events ([#​858](https://togithub.com/probot/probot/issues/858)) ([19fb9d2](https://togithub.com/probot/probot/commit/19fb9d2)) - Cluster support for request throttling ([86f5312](https://togithub.com/probot/probot/commit/86f5312)) - moar Typescript foo ([fa9a228](https://togithub.com/probot/probot/commit/fa9a228)) - new github.paginate API, github.paginate.iterator() ([e0868f1](https://togithub.com/probot/probot/commit/e0868f1)) - new throttling & automated retries ([c6cbc97](https://togithub.com/probot/probot/commit/c6cbc97)) - options.Octokit to pass custom Octokit version ([#​840](https://togithub.com/probot/probot/issues/840)) ([9b11084](https://togithub.com/probot/probot/commit/9b11084)) - standalone run command ([#​751](https://togithub.com/probot/probot/issues/751)) ([bd42feb](https://togithub.com/probot/probot/commit/bd42feb)) ##### Deprecations - `context.github.query()` is now `context.github.graphql()` - `context.github.query(query, variables, headers)` is now `context.github.graphql(query, options)`. `options.headers` is passed as headers. Other options are passed as variables, with the exception of `method`, `baseUrl`, `url`, `headers`, `request`, and `query`. - `context.github.paginate(promise, mapFn)` is now `context.github.paginate(requestOptions, mapFn)`. Example: Before ```js const allIssues = await context.github.paginate( context.github.issues.getAll(context.repo()) ) ``` After ```js const allIssues = await context.github.paginate( context.github.issues.getAll.endpoint.merge(context.repo()) ) ``` ##### Bug Fixes - create only a single redis connection when REDIS_URL is set ([6638331](https://togithub.com/probot/probot/commit/6638331)) - error.code => error.status ([#​871](https://togithub.com/probot/probot/issues/871)) ([596a42d](https://togithub.com/probot/probot/commit/596a42d)) - make `.issues.addLabels()` compatible with current GHE versions ([aa1c570](https://togithub.com/probot/probot/commit/aa1c570)) - make smee-client requirement optional again ([#​868](https://togithub.com/probot/probot/issues/868)) ([1581315](https://togithub.com/probot/probot/commit/1581315)) - pass baseUrl option to [@​octokit/app](https://togithub.com/octokit/app) ([#​839](https://togithub.com/probot/probot/issues/839)) ([eab6851](https://togithub.com/probot/probot/commit/eab6851)) - remove deprecated "simulate" command ([57587b8](https://togithub.com/probot/probot/commit/57587b8)) - remove deprecated `catchErrors` constructor option ([f46c41c](https://togithub.com/probot/probot/commit/f46c41c)) - remove handling deprecated `.event` property ([1f76ec6](https://togithub.com/probot/probot/commit/1f76ec6)) - **logging:** error.status is the new error.code. The old error.status is no more ([2918249](https://togithub.com/probot/probot/commit/2918249)) - **package:** update pkg-conf to version 3.0.0 ([b77e06c](https://togithub.com/probot/probot/commit/b77e06c)) - remove unnecessary escaping in private key error message ([#​862](https://togithub.com/probot/probot/issues/862)) ([8c47d1f](https://togithub.com/probot/probot/commit/8c47d1f)) - Update dependencies ([#​870](https://togithub.com/probot/probot/issues/870)) ([d32ce60](https://togithub.com/probot/probot/commit/d32ce60)) - **typescript:** [@​octokit/webhooks](https://togithub.com/octokit/webhooks) import ([#​854](https://togithub.com/probot/probot/issues/854)) ([30ac1a4](https://togithub.com/probot/probot/commit/30ac1a4)) ### [`v8.0.0-octokit-16-preview.7`](https://togithub.com/probot/probot/compare/0bef3b910aee2671ee18138738d9d486488b22f4...0bef3b910aee2671ee18138738d9d486488b22f4) [Compare Source](https://togithub.com/probot/probot/compare/0bef3b910aee2671ee18138738d9d486488b22f4...0bef3b910aee2671ee18138738d9d486488b22f4) ### [`v8.0.0-octokit-16-preview.6`](https://togithub.com/probot/probot/compare/0bef3b910aee2671ee18138738d9d486488b22f4...0bef3b910aee2671ee18138738d9d486488b22f4) [Compare Source](https://togithub.com/probot/probot/compare/0bef3b910aee2671ee18138738d9d486488b22f4...0bef3b910aee2671ee18138738d9d486488b22f4) ### [`v8.0.0-octokit-16-preview.5`](https://togithub.com/probot/probot/compare/0d20bf56c43f3b81540ae7a35cc4fb0f612f118e...0bef3b910aee2671ee18138738d9d486488b22f4) [Compare Source](https://togithub.com/probot/probot/compare/0d20bf56c43f3b81540ae7a35cc4fb0f612f118e...0bef3b910aee2671ee18138738d9d486488b22f4) ### [`v8.0.0-octokit-16-preview.4`](https://togithub.com/probot/probot/compare/862ebf611e36fe0fbc0510ebbd95da5c5819bd67...0d20bf56c43f3b81540ae7a35cc4fb0f612f118e) [Compare Source](https://togithub.com/probot/probot/compare/862ebf611e36fe0fbc0510ebbd95da5c5819bd67...0d20bf56c43f3b81540ae7a35cc4fb0f612f118e) ### [`v8.0.0-octokit-16-preview.3`](https://togithub.com/probot/probot/compare/79ca87a3c013d183c0d6c7e15fac5d8c53791708...862ebf611e36fe0fbc0510ebbd95da5c5819bd67) [Compare Source](https://togithub.com/probot/probot/compare/79ca87a3c013d183c0d6c7e15fac5d8c53791708...862ebf611e36fe0fbc0510ebbd95da5c5819bd67) ### [`v8.0.0-octokit-16-preview.2`](https://togithub.com/probot/probot/compare/58b6fd12c40954ad457b0e40ff0fc90da0fc1117...79ca87a3c013d183c0d6c7e15fac5d8c53791708) [Compare Source](https://togithub.com/probot/probot/compare/58b6fd12c40954ad457b0e40ff0fc90da0fc1117...79ca87a3c013d183c0d6c7e15fac5d8c53791708) ### [`v8.0.0-octokit-16-preview`](https://togithub.com/probot/probot/compare/3015e3f4857d528cb2181070fa805045656212fb...58b6fd12c40954ad457b0e40ff0fc90da0fc1117) [Compare Source](https://togithub.com/probot/probot/compare/3015e3f4857d528cb2181070fa805045656212fb...58b6fd12c40954ad457b0e40ff0fc90da0fc1117) ### [`v8.0.0-beta.12`](https://togithub.com/probot/probot/compare/e367c81a0bfd96be625e2565265110a5d9bed7d9...3015e3f4857d528cb2181070fa805045656212fb) [Compare Source](https://togithub.com/probot/probot/compare/e367c81a0bfd96be625e2565265110a5d9bed7d9...3015e3f4857d528cb2181070fa805045656212fb) ### [`v8.0.0-beta.11`](https://togithub.com/probot/probot/compare/9dd9a15a0ffc3c22fa7f5b80b0783c53f43527e7...e367c81a0bfd96be625e2565265110a5d9bed7d9) [Compare Source](https://togithub.com/probot/probot/compare/9dd9a15a0ffc3c22fa7f5b80b0783c53f43527e7...e367c81a0bfd96be625e2565265110a5d9bed7d9) ### [`v8.0.0-beta.10`](https://togithub.com/probot/probot/compare/067966f668666ca332b20de99245bfbf57343077...9dd9a15a0ffc3c22fa7f5b80b0783c53f43527e7) [Compare Source](https://togithub.com/probot/probot/compare/067966f668666ca332b20de99245bfbf57343077...9dd9a15a0ffc3c22fa7f5b80b0783c53f43527e7) ### [`v8.0.0-beta.9`](https://togithub.com/probot/probot/compare/bae828513362a992deb29dcacb3a5ab6324c9083...067966f668666ca332b20de99245bfbf57343077) [Compare Source](https://togithub.com/probot/probot/compare/bae828513362a992deb29dcacb3a5ab6324c9083...067966f668666ca332b20de99245bfbf57343077) ### [`v8.0.0-beta.8`](https://togithub.com/probot/probot/compare/8f949e2297f0a1101e3c94c4904d4aefe2fb9e71...bae828513362a992deb29dcacb3a5ab6324c9083) [Compare Source](https://togithub.com/probot/probot/compare/8f949e2297f0a1101e3c94c4904d4aefe2fb9e71...bae828513362a992deb29dcacb3a5ab6324c9083) ### [`v8.0.0-beta.7`](https://togithub.com/probot/probot/compare/1c71952a51eb4d86e239cc664c55d7ee42ae7a3e...8f949e2297f0a1101e3c94c4904d4aefe2fb9e71) [Compare Source](https://togithub.com/probot/probot/compare/1c71952a51eb4d86e239cc664c55d7ee42ae7a3e...8f949e2297f0a1101e3c94c4904d4aefe2fb9e71) ### [`v8.0.0-beta.6`](https://togithub.com/probot/probot/compare/dc592075e59c719972992bb813f056dd0a3287a5...1c71952a51eb4d86e239cc664c55d7ee42ae7a3e) [Compare Source](https://togithub.com/probot/probot/compare/dc592075e59c719972992bb813f056dd0a3287a5...1c71952a51eb4d86e239cc664c55d7ee42ae7a3e) ### [`v8.0.0-beta.5`](https://togithub.com/probot/probot/compare/424d3179ec77a0cdd2359be82bf1f1820501de7d...dc592075e59c719972992bb813f056dd0a3287a5) [Compare Source](https://togithub.com/probot/probot/compare/424d3179ec77a0cdd2359be82bf1f1820501de7d...dc592075e59c719972992bb813f056dd0a3287a5)

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot. View repository job log here.

sjparkinson commented 5 years ago

Two errors from Octokit.

TypeError: Cannot use 'in' operator to search for 'total_count' in 
    at iterator.next.then.result (/home/circleci/repo/node_modules/@octokit/rest/plugins/pagination/paginate.js:35:25)
TypeError: Cannot use 'in' operator to search for 'total_count' in 
    at iterator.next.then.result (/home/circleci/repo/node_modules/@octokit/rest/plugins/pagination/paginate.js:35:25)

https://github.com/octokit/rest.js/blob/a884b111de79d3258387fc1b6c5dc70189c0a12b/plugins/pagination/paginate.js#L35

sjparkinson commented 5 years ago

When running locally we get a different error:

16:20:18.352Z ERROR probot: Object.defineProperty called on non-object
  TypeError: Object.defineProperty called on non-object
      at Function.defineProperty (<anonymous>)
      at iterator.next.then.result (/Users/samuel.parkinson/Repositories/Financial-Times/tako/node_modules/@octokit/rest/plugins/pagination/paginate.js:44:16)

Looks like this is documented at https://github.com/octokit/rest.js/issues/1283#issuecomment-478831430.

renovate[bot] commented 5 years ago

PR has been edited

:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.