search

Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps
https://financial-times.github.io/x-dash
38 stars 6 forks source link

Update readme versions of node and npm to match package engines key #664

Closed IkeLutra closed 2 years ago

IkeLutra commented 2 years ago

As per the title, I have updated the readme so it matches the current engines key in package.json. This caught me out while setting it up locally. New to the FT so any feedback is most welcome.

ivomurrell commented 2 years ago

Hey, this looks good to me, thanks for the catch! The dangers of automating a migration 😅

Unfortunately, our tests are not set up to run for forked versions of the repository at the moment (I've made a note to review that next week.) Seeing as you already have write access to this repository, would you be able to instead create a branch in the upstream Financial-Times repository instead of your fork, and remake this PR? Sorry for the hassle though at least you've highlighted an issue which we'll want to look into further if that's any consolation...

IkeLutra commented 2 years ago

Thanks @ivomurrell . I thought I didn't have write access but I appear to. Have re-created the PR https://github.com/Financial-Times/x-dash/pull/665