Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps
https://financial-times.github.io/x-dash
38 stars 6 forks source link

ENTST-139 Add Enterprise Sharing to FTR Articles #684

Closed willhoward closed 1 year ago

willhoward commented 1 year ago

This PR tweaks the behaviour of x-gift-article to make a few adjustments concerning Enterprise Sharing. The main difference is that when sharing a free to read article with Enterprise Sharing enabled, users will now see the option to share with Enterprise Sharing alongside the default share option.

This is necessary because articles commonly remain free to read for a short period of time before going behind the paywall and we've had feedback from several Enterprise Sharing clients expressing frustration that the standard links to the article they've shared stop working when this happens. Enterprise Sharing clients can also track how many times their links have been opened and therefore some would prefer to share free to read articles via Enterprise Sharing to have visibility over this.

This behaviour is covered by ticket ENTST-139.

I've added a 'Free with enterprise sharing' option to the Storybook to make this behaviour available to test.

Styling Tweaks

This PR also makes a few minor styling changes to the x-gift-article:

willhoward commented 1 year ago

I think there are some undesired side-effects in these changes:

  1. Button text has now the same colour as background
  2. I'd also suggest add a spacing between the label and the warning icon image

Thanks, these are now fixed