Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps
https://financial-times.github.io/x-dash
38 stars 6 forks source link

RELEASE: share modal rebrand #713

Closed abshirahmed closed 1 year ago

abshirahmed commented 1 year ago

Description

On Monday 10th July "Enterprise" will be rebranding to "Professional". As part of the onsite work for that we are rebranding the gift article modal on the article page. There are no functional changes in this work, but there are a lot of messaging and style changes. Ideally we would like to release this on Friday 7th July, for a soft-launch before the official rebrand on Monday.

Jira card Figma designs

Implementation

What has changed

What has not changed

How we've done it Because much of the styling and messaging has changed (even though the logic hasn't), we've found it easiest to create a v2 of the share-modal and build it up with the new styling and messaging, and then remove the code for the old modal.

We have created a release branch (this one) and then merged different elements of the feature into it via the PRs and commits listed below.

Still to do

Commits

https://github.com/Financial-Times/x-dash/assets/10318770/85561382-48ce-4b9c-8a6e-6c0c93c2570d

https://github.com/Financial-Times/x-dash/assets/10318770/1fc45534-a356-4abb-b30a-6b73e700fc0b

B2C (no credits) B2B (no credits) AS (no gift credits) AS (no enterprise credits)
Screenshot 2023-06-29 at 16 50 56 Screenshot 2023-06-29 at 16 51 15 Screenshot 2023-06-29 at 16 51 23 Screenshot 2023-06-29 at 16 51 28

https://github.com/Financial-Times/x-dash/assets/10318770/d5c8dc20-a454-4236-bfe4-41812351c01d

B2B B2C AS
Screenshot 2023-07-06 at 13 12 33 Screenshot 2023-07-06 at 13 12 36 Screenshot 2023-07-06 at 13 12 54
Screenshot 2023-07-06 at 13 12 41 Screenshot 2023-07-06 at 13 12 44 Screenshot 2023-07-06 at 13 12 57

If this is your first x-dash pull request please familiarise yourself with the contribution guide before submitting.

Release Plan

As there is a lot of new code, we will create a beta release for day one and test it in production. As soon as we are confident that all works as it should (which will be a matter of days, taking into account the weekend) we will release a non-beta version.

joelcarr commented 1 year ago

LOVELY PR description by the way šŸ‘ šŸ‘ šŸ‘ šŸ‘ šŸ‘ Easy to read, extremely informative, brilliant visuals. 10/10.