ENTST-445: user journey flow changes advanced sharing

[abshirahmed]

https://github.com/Financial-Times/x-dash/assets/10318770/85561382-48ce-4b9c-8a6e-6c0c93c2570d

If this is your first x-dash pull request please familiarise yourself with the contribution guide before submitting.

If you're creating a component:

• Add the Component label to this Pull Request
• If this will be a long-lived PR, consider using smaller PRs targeting this branch for individual features, so your team can review them without involving x-dash maintainers
  • If you're using this workflow, create a Label and a Project for your component and ensure all small PRs are attached to them. Add the Project to the Components board
  • put a link to this Pull Request in the Project description
  • set the Project to Automated kanban with reviews, but remove the To Do column
  • If you're not using this workflow, add this Pull Request to the Components board.

• Discuss features first
• Update the documentation
• Must be tested in FT.com and Apps before merge
• No hacks, experiments or temporary workarounds
• Reviewers are empowered to say no
• Reference other issues
• Update affected stories and snapshots
• Follow the code style
• Decide on a version (major, minor, or patch)

[fabiosikansi]

The story "Share this article (without credit)"

looks to me exactly like sharing with credits, not the expected behaviour

EDIT: Same with Free article

[fabiosikansi]

When creating a link I see the message "Link can be viewed undefined times and is valid for 90 days." this doesn't look right to me

[fabiosikansi]

I'd suggest renaming stories "with enterprise sharing" to "with advanced sharing" for consistency

if possible I'd also add a note explaining what Advanced Sharing is because we can expect devs for teams outside FT Professional to browse this code

[fabiosikansi]

Story with enterprise sharing (no credits) doesn't seem to be working as expected for me, I don't see any error message when clicking on "Create link", it is just a broken form

[fabiosikansi]

Unsure what was expected in "With enterprise sharing (first time access)" and "with enterprise sharing (request access)", both look the same as the standard advanced scenario story

[fabiosikansi]

The message "Only FT subscribers will be able to see the full article using this link." is not the expected message when an user creates an advanced sharing link (story "with enterprise sharing (link generated)"

[fabiosikansi]

"Error response" also doesn't show any error so it doesn't look right to me

[abshirahmed]

@fabiosikansi the previous stories may not work as expected because we're still building out the behaviour for each scenario as we go along. To reduce the confusion, all previous storybook stories have been commented out. The current stories are Share article dialog (B2B), Share article dialog (B2C) and Share article dialog (B2B with Advanced Sharing). The remaining sub-tasks in ENTST-439 should hopefully cover the other scenarios.