Closed abshirahmed closed 1 year ago
Just wonder if you also need to initialize oShare in the client side: https://registry.origami.ft.com/components/o-share@9.0.2/jsdoc?brand=core I'm not sure what it does but next-article does it. https://github.com/Financial-Times/next-article/blob/main/client/components/live-blogs/share.js#L3-L12
I'm not sure if this is the part necessary so we open the share options in a pop-up instead of a new page.
Good shout on initialising oShare 👍🏾 Now that it is initialised, clicking on the share button opens up a popup instead of redirecting or opening in a new tab.
https://github.com/Financial-Times/x-dash/assets/10318770/1fc45534-a356-4abb-b30a-6b73e700fc0b
If this is your first
x-dash
pull request please familiarise yourself with the contribution guide before submitting.If you're creating a component:
Component
label to this Pull RequestAutomated kanban with reviews
, but remove theTo Do
column