CPP1466: Migrate x-dash to Node 18 and add support for Node 18 to x-dash packages

Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps

https://financial-times.github.io/x-dash

38 stars 6 forks source link

CPP1466: Migrate x-dash to Node 18 and add support for Node 18 to x-dash packages #720

Closed joelcarr closed 1 year ago

joelcarr commented 1 year ago

I used x-dash to test the migration script and slowly completed the migration. Performing this migration showed our tests failed on Node 18. I updated Jest and its' associated packages. I then came across some ESLint inconsistencies so I updated ESLint and its' associated packages to fix the inconsistencies. Whilst I was there, added the new @dotcom-reliability-kit/eslint-config and @financial-times/eslint-config-next. I then proceeded to fix the ESLint errors.

joelcarr commented 1 year ago

Maggie asked offline if these changes had been tested in systems like next-article. I have just tested these changes in next-article by installing the local version with these changes and running npm run build, then npm start, and loading a selection of articles (live blogs, scrollytelling, toppers etc). I have also tested this with next-search-page with the same instructions and testing the search pages. Everything has been working as expected.

joelcarr commented 1 year ago

As the changes are purely affecting the build setup and not the published code, which is concern of the other codeowners - I am merging this pull request without review from the other codeowners.