Social Share Url Fix in x-gift-article - Githubissues

Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps

https://financial-times.github.io/x-dash

38 stars 6 forks source link

Social Share Url Fix in x-gift-article #737

Closed AnnaDraganova closed 12 months ago

AnnaDraganova commented 12 months ago

Description

Previous behavior
- When a user clicks a social share icon the link associated with the icon is a standard link(even for Advanced Sharing).
Current behavior
- When a user clicks a social share icon the link associated with the icon will be the same as what the user has chosen to generate.

Link to the Jira ticket

https://financialtimes.atlassian.net/browse/ENTST-591

Video Example - Before and After

Now the share link that appears in Twitter's modal is the same as the link generated in the x-gift-article modal.

https://github.com/Financial-Times/x-dash/assets/22678655/f809d226-c12d-410a-8077-9b391d1e774d

AnnaDraganova commented 12 months ago

Thank you for this @AnnaDraganova, could you please just include screen captures of the before/after? You can screen record on mac with command+shift+5.

Added a video in the PR description.