Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps
https://financial-times.github.io/x-dash
38 stars 6 forks source link

Update n-myft-ui #758

Closed camillecroci closed 8 months ago

camillecroci commented 8 months ago

Why ?

HI ! I am updating n-myft-ui because:

  1. The "save article" feature seems to rely on an old session cookie (origin convo)
  2. Alex found that the pb was probably n-myft-ui using an old next-myft-client and updated it.
  3. So now we want that updated n-myft-ui for next-myft-page

And this is where the fun begins. To update n-myft-ui on next-myft-page, I need to update a bunch of stuff :), including having x-follow-button using the last n-myft-ui.

What are the changes on n-myft-ui

  1. Of course it got that update for next-myft-client, which is what we want here.
  2. It also got some minor support work for n-ui-foundation
  3. It is now using react 17 ! But from react themselves, "The React 17 release is unusual because it doesn’t add any new developer-facing features. Instead, this release is primarily focused on making it easier to upgrade React itself." (source) so I think it's all good.
  4. The error message style has changed, which should not affect us here
  5. It also supports node 18

Test

How did I test that?
I ran the tests. lol.
I also checked storybook.
I linked x-follow-button to next-myft-page on my machine and run it and tried playing with it, including on different screen sizes and it looks like nothing broke.