Financial-Times / x-dash

:x::heavy_minus_sign::newspaper: shared front-end components for FT.com and the FT Apps
https://financial-times.github.io/x-dash
38 stars 6 forks source link

feat: rename promo content wrapper to match image container #775

Closed metart43 closed 4 months ago

metart43 commented 4 months ago

This change applies the existing logic added to the image container on the ft-app. We can avoiding duplication of this logic for the promotional content wrapper in the ft-app and wouldn't need to replicate it for the new class name.

note:

Downside of this method is the situation where promotional content has a class name of o-teaser__image-container, but it is way safer than trying to rename this class and image container class to something like o-teaser__media-container.

We do have the same logic for the next-home-page where we reused the existing image class name for the teaser image and the clip component.