This PR fixes a couple of issues related to the 'share with highlights' feature.
Currently, whenever a user selects "FT subscribers only", even if the article contains no highlights for the user, we still request a highlights access token.
Whenever the user selected "FT subscribers only", we setIncludeHighlights to the value of the "Anyone/FT subscribers only" switcher, which evaluates to true. This is an issue particularly when the article contains no highlights, as we don't display the 'Include Highlights' checkbox, but we're still setting it to true.
This PR makes sure that we're only setting includeHighlights when the user wishes to.
It also adds some error handling to the code that requests the highlights token. Currently this endpoint does not return an error, but it soon will in an upcoming change to the Highlights backend, where the /create-token route will return 404 when the given article contains no highlights.
This PR fixes a couple of issues related to the 'share with highlights' feature.
Currently, whenever a user selects "FT subscribers only", even if the article contains no highlights for the user, we still request a highlights access token.
Whenever the user selected "FT subscribers only", we
setIncludeHighlightsto the value of the "Anyone/FT subscribers only" switcher, which evaluates to true. This is an issue particularly when the article contains no highlights, as we don't display the 'Include Highlights' checkbox, but we're still setting it to true.This PR makes sure that we're only setting
includeHighlightswhen the user wishes to.It also adds some error handling to the code that requests the highlights token. Currently this endpoint does not return an error, but it soon will in an upcoming change to the Highlights backend, where the /create-token route will return 404 when the given article contains no highlights.