Finastra / finastra-design-system

The Finastra Design System provided as a theme and components library
https://design.fusionfabric.cloud/
MIT License
123 stars 44 forks source link

correct chart doc #926

Closed dorsaffrigui closed 1 year ago

dorsaffrigui commented 1 year ago

Describe the bug

In radial-bar-chart usage section, the code refers to pie-chart, which is confusing. The code snippet doesn't work as well

To Reproduce Steps to reproduce the behavior:

  1. Go to https://finastra.github.io/finastra-design-system/?path=/docs/data-display-charts-radial-bar-chart--default
  2. in the usage section we have an example of only fds-pie-chart while we are in radial bar chart doc

Expected behavior provide 3 examples or try to find a way to make this dynamic

import '@finastra/charts';

<fds-pie-chart width="380" data='[44, 55, 13, 43, 22]' label="['Apple', 'Mango', 'Orange', 'Watermelon', 'Wiki']"></fds-pie-chart>

<fds-radial-chart width="380" data='[44]'></fds-pie-chart>

<fds-donut-chart color="categorical" width="300px" height="300px"></fds-donut-chart>
stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

ttalbot commented 1 year ago

We have a similar approach for button. giving code snippet for all 3 types of button.

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.