search

Finbuckle / Finbuckle.MultiTenant

Finbuckle.MultiTenant is an open-source multitenancy middleware library for .NET. It enables tenant resolution, per-tenant app behavior, and per-tenant data isolation.
https://www.finbuckle.com/multitenant
Apache License 2.0
1.3k stars 265 forks source link

Duplicate call of GetIdentifierAsync in Strategy Wrapper #163

Closed danjus10 closed 4 years ago

danjus10 commented 5 years ago

image

Remove line 57. identifier is already set .

danjus10 commented 5 years ago

I tried to push a PR to fix but not sure why its blocked. anyways - Thanks for the awesome lib. v nice !

AndrewTriesToCode commented 5 years ago

hi @danjus10 I'm not sure why it wouldn't allow you to submit a PR-- I need to check on that.

Good catch on this bug!

danjus10 commented 5 years ago

Thanks for the quick response 👍

Where is the best place to ask question about the libraries? I'm trying to decide if it supports multiple tenant strategies. e.g WithDelegateStrategy fallsback to WithRouteStrategy if no tenant, found is that possible?

AndrewTriesToCode commented 5 years ago

This issues area is the best place for these questions. I'm planning on that feature in the next release, but currently only a single strategy is used (except if you use fallback too).

danjus10 commented 5 years ago

This issues area is the best place for these questions. I'm planning on that feature in the next release, but currently only a single strategy is used (except if you use fallback too).

Ok cool. I'll keep an eye out.

AndrewTriesToCode commented 5 years ago

Hi @danjus10 can you please try to submit a PR for this and let me know? I just released a new version but I didn't include this bug fix yet. Thanks!

danjus10 commented 5 years ago

No dice. i'm logged in for sure. Maybe check the repo permissions. ?

[cid:f4fb5968-fd2d-4f3f-bf79-77cec36bc0fd]

From: Andrew White notifications@github.com Sent: 08 September 2019 06:29 To: Finbuckle/Finbuckle.MultiTenant Finbuckle.MultiTenant@noreply.github.com Cc: Dan Justin dan@fluidbsg.com; Mention mention@noreply.github.com Subject: Re: [Finbuckle/Finbuckle.MultiTenant] Duplicate call of GetIdentifierAsync in Strategy Wrapper (#163)

Hi @danjus10https://github.com/danjus10 can you please try to submit a PR for this and let me know? I just released a new version but I didn't include this bug fix yet. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Finbuckle/Finbuckle.MultiTenant/issues/163?email_source=notifications&email_token=AI3FBIDWEBXKMCDXGP2GTIDQISESRA5CNFSM4IKUFRU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FIGPI#issuecomment-529171261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI3FBIFQEXCDPGFTLQTRXLDQISESRANCNFSM4IKUFRUQ.

AndrewTriesToCode commented 5 years ago

Hm, that's not good. I don't currently see that you have a fork of the project-- you had one when you tried to submit though right? I checked the settings but didn't see anything obvious. My understanding is that anyone with read access to a public repo can submit a PR from their own fork.

Just to narrow things down, can you tell me at which step in the github docs for submitting a pull request that you can't get any further?

danjus10 commented 4 years ago

Oh I see! I was trying to do a branch & PR directly in your repo rather than a fork etc

Thanks for your patience [new to github contribution] ✌

Dan

From: Andrew White notifications@github.com Sent: 09 September 2019 17:39 To: Finbuckle/Finbuckle.MultiTenant Finbuckle.MultiTenant@noreply.github.com Cc: Dan Justin dan@fluidbsg.com; Mention mention@noreply.github.com Subject: Re: [Finbuckle/Finbuckle.MultiTenant] Duplicate call of GetIdentifierAsync in Strategy Wrapper (#163)

Hm, that's not good. I don't currently see that you have a fork of the project-- you had one when you tried to submit though right? I checked the settings but didn't see anything obvious. My understanding is that anyone with read access to a public repo can submit a PR from their own fork.

Just to narrow things down, can you tell me at which step in the github docs for submitting a pull requesthttps://help.github.com/en/articles/creating-a-pull-request-from-a-fork that you can't get any further?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Finbuckle/Finbuckle.MultiTenant/issues/163?email_source=notifications&email_token=AI3FBIAMT66WRR62CQ43MF3QIZ35BA5CNFSM4IKUFRU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6IIFWA#issuecomment-529564376, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI3FBIAONMPM5VRFWBX2HR3QIZ35BANCNFSM4IKUFRUQ.

AndrewTriesToCode commented 4 years ago

Excellent. No worries it is confusing--I totally messed up someone else's PR earlier today.