search

Findus23 / matomo-DiagnosticsExtended

2 stars 3 forks source link

System Check becomes unavailable when internet is disabled #13

Open heurteph-ei opened 1 year ago

heurteph-ei commented 1 year ago

Hi @Findus23 When I am using the DiagnosticsExtended (v0.1.9) plugin, my Diagnostic > System Check becomes unavailable: image

Matomo 4.14.2 PHP 7.3.33

Error log:

Uncaught exception: /plugins/DiagnosticsExtended/Diagnostic/MatomoJsCheck.php(51): internet is disabled [Query: ?module=Installation&action=systemCheckPage&idSite=3&period=day&date=today&activated=, CLI mode: 0]

Very strange when I see the changelog:

0.1.3 (unpublished)

  • remove logged warning from PHP check
  • don't fail if headers are missing
  • skip checks when enable_internet_features = 0 is set
  • also accept brotli compression

Everything comes to normal when I disable the DiagnosticsExtended (v0.1.9) plugin.

Additional question: Does this plugin need Internet for all tests? Maybe tests needing Internet should be documented...