search

Findus23 / matomo-DiagnosticsExtended

2 stars 3 forks source link

Improve config.ini.php HTTP accessibility check #7

Closed d--j closed 2 years ago

d--j commented 2 years ago

My custom 404 error page has a ";" in it and thus creates a false positive warning that the config.ini.php file gets executed as PHP.

404/403 error pages containing ";" or "salt" should not trigger an error or warning.

Findus23 commented 2 years ago

Hi,

This change makes sense, but I'll probably remove this check soon as an equivalent is now included in Matomo.

Findus23 commented 2 years ago

I removed this check now in https://github.com/Findus23/matomo-DiagnosticsExtended/commit/c84cbae6c59d86bba84c3d59286b491877a191d0

Findus23 commented 2 years ago

And this and #8 should now be part of the new 0.1.9 release. Thanks for the contributions!