search

FineFindus / eyedropper

Pick and format colors
https://apps.gnome.org/Eyedropper
GNU General Public License v3.0
260 stars 26 forks source link

appdata: `translate=no` properties #133

Open yakushabb opened 5 months ago

yakushabb commented 5 months ago

It appears that the appstream project no longer supports translatable=no properties, and gettext extract the translatable=no marked strings as translatable.

I opened an issue to inform about the situation, but translatable=no properties are not accepted by developers. You can find the issue here: https://github.com/ximion/appstream/issues/623

Please test your script or string extraction process before merging this PR.

In MetaInfo files, each individual paragraph of a description (or enumerated entry) is translated individually, however, you can only exclude the complete block from being translated by adding translate="no" to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html

FineFindus commented 4 months ago

Sorry for the long pause.

Please test your script or string extraction process before merging this PR.

I'm using the scripts/make-pot.sh script, after running it with the changes, it seems like it does not recognize the new property.

yakushabb commented 4 months ago

Your metainfo rules might not be updated due to gettext not yet accepted the patch.

You can find your metainfo related files, back up them, then update from the following appstream files.

https://github.com/ximion/appstream/blob/main/data/its/metainfo.loc https://github.com/ximion/appstream/blob/main/data/its/metainfo.its

Related topic/comments:

FineFindus commented 4 months ago

I'm a bit confused about what files I should replace? Is there any ETA on when the patch may be included? I feel like that would be a better solution.

yakushabb commented 3 months ago

No ETA. Also no action from gettext side.