search

FineFindus / eyedropper

Pick and format colors
https://apps.gnome.org/Eyedropper
GNU General Public License v3.0
260 stars 26 forks source link

UI: CIE illuminants dropdown does not fit it's content #22

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi, the new CIE illuminants list does not fit it's content properly. It's not showing longer strings.

To Reproduce Steps to reproduce the behavior:

  1. Open Eyedropper.
  2. Go to Preferences
  3. Try to select something from "CIE standard observer"

Screenshots eaeae (Icons not important)

Information

The line of strings: https://github.com/FineFindus/eyedropper/blob/master/data/resources/ui/preferences.ui#L50-L69

ghost commented 1 year ago

I think it was related to GTK4 but I couldn't find enough information.

FineFindus commented 1 year ago

Thanks for the report, I'm aware of it. Since the UI is built using AdwPreference widgets, this is probably an upstream bug. I will be trying to fix this or open an issue on the libadwaita repo.

Also, the missing icons are a result from the custom icon theme, it seems like most icon themes do not include the list-drag-handle-symbolic icons.

FineFindus commented 1 year ago

I've opened a bug report on the libadwaita GitLab.

I'm closing this for now, since there is nothing else I can do right now. If I find a solution for it, or the bug gets fixed, I will reopen this.

FineFindus commented 1 year ago

Never mind, I fix it.

Image It's a bit hacky, does not always look the prettiest, since it changes its width when the selected item is changed, but I think that is acceptable.