search

FineFindus / eyedropper

Pick and format colors
https://apps.gnome.org/Eyedropper
GNU General Public License v3.0
260 stars 26 forks source link

added oklab and oklch #99

Closed Shayan418 closed 10 months ago

Shayan418 commented 10 months ago

Fix #96 Adds Oklch support along with oklab color space

FineFindus commented 10 months ago

From a quick look at it, it looks good. Let me know when this is ready for a full review :)

Shayan418 commented 10 months ago

Its good for review. I was wondering if i can format the output for these to follow the css Functional notation

  1. remove comma
  2. '/' before alpha value at the end
Shayan418 commented 10 months ago

Thanks for your input, I made the required changes. Formatted with clippy.

Fixed the output format to match css notation.

Screenshot from 2023-11-13 02-08-42

Shayan418 commented 10 months ago

done, changed all calculations to f64. I thought to use f64 as return value to not loose the precision when converting from oklab to oklch.

Didn't realize clippy was not working because it couldn't find the APP_ID values. had to run meson --prefix=/usr build before to fix that error.

FineFindus commented 10 months ago

Thanks, greatly appreciate the work you did :tada:

Shayan418 commented 10 months ago

Glad I could help.