search

FineUploader / fine-uploader

Multiple file upload plugin with image previews, drag and drop, progress bars. S3 and Azure support, image scaling, form support, chunking, resume, pause, and tons of other features.
https://fineuploader.com
MIT License
8.18k stars 1.87k forks source link

Black preview thumbnails on FF with wide images #1213

Closed yairEO closed 10 years ago

yairEO commented 10 years ago

Tested on Win7 / FF29

Seems like the preview thumbnail is rendered completely black when I choose a source image which is very wide. I've taken those photos myself with my Nexus 5 phone. They are panorama. Here's a link to one of them:

http://dropthebit.com/demos/PANO_20140427_191305.jpg

Is it something that can be fixed by javascript or is it a browser bug?

rnicholus commented 10 years ago

I just tested in Chrome 35 on a chromebook, and your image rendered correctly as a preview. I'll look at more browsers when I am near a real computer later.

On Thu, May 22, 2014 at 7:19 AM, vsync notifications@github.com wrote:

Tested on Win7 / FF29

Seems like the preview thumbnail is rendered completely black when I choose a source image which is very wide. I've taken those photos myself with my Nexus 5 phone. They are panorama. Here's a link to one of them:

http://dropthebit.com/demos/PANO_20140427_191305.jpg

Is it something that can be fixed by javascript or is it a browser bug?

— Reply to this email directly or view it on GitHubhttps://github.com/Widen/fine-uploader/issues/1213 .

yairEO commented 10 years ago

yes because it works on Chrome...As I said in my issue, this is a Firefox issue.

rnicholus commented 10 years ago

Your issue says that you tested on Win7 / FF 29. Nothing about testing/results in other browsers. If you mentioned that it worked in everything other than FF29, I would have not started to test in other browsers first. And, as I said, I'll do more investigation myself once I am near a real computer. Please try to be a little patient.

On Thu, May 22, 2014 at 8:04 AM, vsync notifications@github.com wrote:

yes becuase it works on chome...I said my my issue, this is a Firefox issue.

— Reply to this email directly or view it on GitHubhttps://github.com/Widen/fine-uploader/issues/1213#issuecomment-43884499 .

yairEO commented 10 years ago

yeah well, I was assuming you will start testing in the exact same conditions under which I have mentioned, to make sure this issue is valid...I am patient, I know you guys are really nice people and doing your best on this great plugin.

feltnerm commented 10 years ago

Unable to reproduce using your test image on FF 29.0.1 on Windows 7.

screen shot 2014-05-22 at 11 41 47

@yairEO -- any other steps to reproduce? Otherwise I vote we close this.

yairEO commented 10 years ago

fine_uploader_demo_-_2014-05-24_21 04 16

It might be anything...my graphic drivers even. who knows. I really hope it only happens on my machine and not on any other, but it's the only place I've ever seen this happens. with this script, so this is why I'm stating that. I've tried this with other uploading solutions I've found on google, such as http://www.dropzonejs.com/ and they preview works ok. So, logic suggests that this is a fineuploader issue.

rnicholus commented 10 years ago

Can you provide some more specific information about your setup, browser extensions, etc? You are the first to report such an issue, and the previewing feature has been out for quite a while. The image manipulation code is fairly non-trivial in order to support all of the features we offer, but, for the most part, we rely on <canvas>.

rnicholus commented 10 years ago

I should mention that video drivers are unlikely to be the culprit. Perhaps a browser extension is causing an issue.

On Saturday, May 24, 2014, vsync notifications@github.com wrote:

[image: fine_uploaderdemo-_2014-05-24_21 04 16]https://cloud.githubusercontent.com/assets/845031/3075273/efc46262-e36d-11e3-8d07-4f8d4e786b3c.png

It might be anything...my graphic drivers even. who knows. I really hope it only happens on my machine and not on any other, but it's the only place I've ever seen this happens. with this script, so this is why I'm stating that. I've tried this with other uploading solutions I've found on google, such as http://www.dropzonejs.com/ and they preview works ok. So, logic suggests that this is a fineuploader issue.

— Reply to this email directly or view it on GitHubhttps://github.com/Widen/fine-uploader/issues/1213#issuecomment-44094932 .

yairEO commented 10 years ago

yes, it is probably an extension. I've just tried to restart Firefox in safe mode and that black thumbnail hadn't occurred. As a developer, I have 20 addons right now, I am too lazy to disable each one and then restart Firefox and check which one is responsible for the issue, it is too time-consuming

rnicholus commented 10 years ago

If you can provide us with a list of your extensions, that would be helpful.

On Saturday, May 24, 2014, vsync notifications@github.com wrote:

yes, it is probably an extension. I've just tried to restart Firefox in safe mode and that black thumbnail hadn't occurred. As a developer, I have 20 addons right now, I am too lazy to disable each one and then restart Firefox and check which one is responsible for the issue, it is too time-consuming

— Reply to this email directly or view it on GitHubhttps://github.com/Widen/fine-uploader/issues/1213#issuecomment-44095642 .

yairEO commented 10 years ago
Name version enabled
Adblock Plus 2.6 true
BrowserStack Local 5.2 true
ColorZilla 2.8 true
CSS Reloader 1.0.5 true
Download Status Bar 9.9.1 true
Firebug 1.12.8 true
Firebug Autocompleter 1.4.1 true
Firebug Paint Events 0.1.8 true
FireFontFamily 0.1.2 true
FireQuery 1.4.1 true
Free Memory 0.95 true
Html Validator 0.9.5.8 true
Image Zoom 0.6.3 true
MeasureIt 0.4.13 true
Screengrab (fix version) 0.97.24c true
SelectBug 0.1a4 true
Tab Mix Plus 0.4.1.3.1 true
Text Font-Size Adjuster 0.94.18 true
Web Developer 1.2.5 true
X-notifier 3.4 true
Adobe Acrobat - Create PDF 1.2 false
Download Statusbar 0.9.10 false
YSlow 3.1.8 false
rnicholus commented 10 years ago

Thanks! Once we determine which extension is causing the issue, we will take the most appropriate action to work around or document the issue.

On Saturday, May 24, 2014, vsync notifications@github.com wrote:

Name version enabled Adblock Plus 2.6 true BrowserStack Local 5.2 true ColorZilla 2.8 true CSS Reloader 1.0.5 true Download Status Bar 9.9.1 true Firebug 1.12.8 true Firebug Autocompleter 1.4.1 true Firebug Paint Events 0.1.8 true FireFontFamily 0.1.2 true FireQuery 1.4.1 true Free Memory 0.95 true Html Validator 0.9.5.8 true Image Zoom 0.6.3 true MeasureIt 0.4.13 true Screengrab (fix version) 0.97.24c true SelectBug 0.1a4 true Tab Mix Plus 0.4.1.3.1 true Text Font-Size Adjuster 0.94.18 true Web Developer 1.2.5 true X-notifier 3.4 true Adobe Acrobat - Create PDF 1.2 false Download Statusbar 0.9.10 false YSlow 3.1.8 false

— Reply to this email directly or view it on GitHubhttps://github.com/Widen/fine-uploader/issues/1213#issuecomment-44100066 .

rnicholus commented 10 years ago

Sounds like an extension is the culprit. Nothing we can do about that.