search

FineUploader / server-examples

Server-side examples for the Fine Uploader library
https://fineuploader.com
MIT License
279 stars 204 forks source link

Fixed some code style inconsistencies in NodeJS example #53

Closed SamuelBolduc closed 8 years ago

SamuelBolduc commented 8 years ago

I'm really not sure what are the code standards in the project for NodeJS, but there were some obvious inconsistencies here and there. I fixed those, without changing chosen code styles.

CLAassistant commented 8 years ago

CLA assistant check
All committers have signed the CLA.

rnicholus commented 8 years ago

I'm really not sure what are the code standards in the project for NodeJS

Neither am I! This could benefit from an .editorconfig file and the some code style enforcement. But those are both among many (many) low-priority Fine Uploader-related items on my list at the moment.

Thanks for the contribution. I'll take a closer look soon. The version number in the package.json should be update to indicate that this is a hotfix revision. If you have any other suggestions, do let me know (or open up another PR).

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

SamuelBolduc commented 8 years ago

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

Yup, just tested, everything still works fine.

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

I bumped the patch version in https://github.com/FineUploader/server-examples/pull/53/commits/423af6f1a91a9e52acbbb31c0e57d572ff52f8e9

This could benefit from an .editorconfig file and the some code style enforcement.

I agree. When I have the time I might take on that task - it should not be very hard to upgrade the code to actual Javascript style standards.