FineUploader / server-examples

Server-side examples for the Fine Uploader library
https://fineuploader.com
MIT License
279 stars 204 forks source link

Ruby on Rails example app #60

Closed Panczo closed 6 years ago

Panczo commented 7 years ago

Hi I have recently written application using ReactFineUploader with my rails app. I had made example app and i thought this example app would be great for others rails developers. I was using rails with carrierwave in order to handle files in the backend. For my view layer i was using react from react_webpack_rails gem.

Best

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

rnicholus commented 7 years ago

Hey, wow, lots of work went into this. I think it would be best if we put this into a dedicated repository under the Fine Uploader organization. How does that sound? After this is moved, we can talk about additional changes before this is published for other rails developers to benefit from.

Panczo commented 7 years ago

Yes, of course, it's great idea. And what do you mean by additional changes ? :)

rnicholus commented 7 years ago

What I mean by "additional changes" is that I haven't taken the opportunity to review your code yet, so I might have other suggestions once this is moved to a new repo. I'll create a new one shortly.

Panczo commented 7 years ago

@rnicholus I improved rails with reactfineuploader example app. You can grab it from repo url and put it under Fine Uploader organization.

rnicholus commented 7 years ago

I can certainly do that, or to avoid simply copying the repo, would you be interested in transferring it into the FineUploader organization? I would make you the admin of the repo, of course.

Panczo commented 7 years ago

Ok no problem, i can transfer it to FineUploader organization.

rnicholus commented 7 years ago

Great! I just invited you to the Fine Uploader "transfer" organization. Because GitHub's permissions system is inherently flawed and transferring a repo in requires providing "god" access to the entire org, I created an intermediary org for this purpose. Once your repo is transferred into the transfer org, I'll transfer it on to @FineUploader and then give you admin access to the repo.

rnicholus commented 6 years ago

moved to https://github.com/FineUploader/react-fine-uploader-rails