FingerLakesRunnersClub / Leaderboards

Leaderboards for the FLRC Challenge and Trail Circuit
https://fingerlakesrunners.org
GNU General Public License v3.0
0 stars 0 forks source link

Team average age-grading calculation correct? #39

Closed adamengst closed 3 years ago

adamengst commented 3 years ago

As a competitor, it seems that the 50-59 team's average age grade looks wrong at the moment. At the moment, there are only two runners, Sean and me, and our individual best efforts are a 77.36% for Sean and 75.86% for me. So I'd expect a team average age grade of 76.61% given that those are our best efforts and we're the top "10" runners on the team right now. But the leaderboard is showing our average age-grade as 53.61%.

https://challenge.fingerlakesrunners.org/Course/233198/Team

I suspect that it's averaging all efforts for the top 10 runners, rather than just the best effort. That's undesirable because it penalizes fast runners if they run easy efforts along with their fast times.

Acceptance criteria:

SteveDesmond-ca commented 3 years ago

Looks like it's sorting the athletes by their fastest time, but not their individual runs, so it's instead picking their first run (e.g. your 8:15) rather than their fastest (e.g. your 5:49)

Should be an easy fix, will have something out within the hour.

SteveDesmond-ca commented 3 years ago

Fixed as of b28d466