Add obvious visual indicators when age grade >100%

[SteveDesmond-ca]

As an RD, I want invalid results to pop out, so I don't need to do as much digging to find out why everyone's scores got messed up.

Acceptance criteria:

• results rows in the "fastest" table are highlighted in red if the age grade is >100%
• a message is displayed at the top of the athlete's page about invalid results, so they might have a better chance of spotting it themselves

[SteveDesmond-ca]

Upon further playing with the data, and considering how much this is coming up, I think a better course of action is to not count an athlete's invalid result from a course until it is fixed. (where invalid = age grade >100%)

This way, they are the only one affected by the data entry error -- right now, everyone's overall points are thrown off because the change in points for a single course rearranges many rankings/positions, depending on who's run that course and how fast they ran.

We would probably need to make it much clearer from the athlete info page that their invalid result needs to be fixed.

Thoughts, @adamengst?

[adamengst]

I see what you're saying, and I agree that it would be better not to throw everything off until I get the spurious data fixed.

The real question is how we're alerted. Right now, I see something weird, like Adam Pacheck not having a clean divisible by 100 score, and that makes me dig further.

Could you mark a result as questionable throughout? For instance, by displaying it in red?

[SteveDesmond-ca]

It'd be easy enough to do something like this:

But the onus is still on you to get all the data right so no one else is mixed up.

If we just remove the record, we could always (in addition to showing it on the athlete's page) add a "hidden" page with invalid results so you can still check in from time to time and proactively poke people to fix their data, but it wouldn't be nearly as urgent because everyone else would still be good. This puts the onus on the athlete to fix their own data, so they can get the points they deserve.

[adamengst]

I think I prefer the idea of removing the record from the public report and displaying it on both the athlete page under Questionable Results and on a hidden page I can check from time to time.

The problem with marking it on the race page, as I now see above, is that it will always be the top entry, so it's not clear what the marking means. In the Activity Log, where it would sort with all the rest, the markings would be more obvious. But there's no need to embarrass people in public over their mistakes.

[SteveDesmond-ca]

This was a little more complicated than expected, but I think we're ready to go live with it tonight. Not sure if you wanted to include a note with the weekly recap about the change, since it really only affects a small subset of users (those who submit invalid times) but here's the basic workflow:

If a user notices a drastic decrease in their overall points, or if they check their athlete page for any other reason when they have an invalid result (where an invalid result has an age grade > 100%), they'll see the following:

The "Invalid Results" page shows invalid results for any courses that have them, or a happy green message if there aren't any:

The "View All Runs" list from the athlete's page will also show their invalid result(s) for that course, at the top with a rank of 0.

[adamengst]

Looks good! I'll mention it briefly in the recap...

[SteveDesmond-ca]

Implemented as of 7ff6346