Finii
commented
5 months ago To catch too-wide glyphs after patching we have code that checks the patched font (each glyph individually) in the end for monospace-iety. Overlap is allowed/needed for some glyphs - the powerline 'landing platform'.
# Check if the inserted glyph is scaled correctly for monospace
if self.args.single:
(xmin, _, xmax, _) = self.sourceFont[currentSourceFontGlyph].boundingBox()
if int(xmax - xmin) > self.font_dim['width'] * (1 + (overlap or 0)):
logger.warning("Scaled glyph %X wider than one monospace width (%d / %d (overlap %s))",
currentSourceFontGlyph, int(xmax - xmin), self.font_dim['width'], repr(overlap))Hmm, it just takes the width of the bounding box, which would not detect if the glyph is shifted outside the 'cell', but the code did catch a lot problems in the past even as it is.
aaronbell
On examining the result of the NF2 branch preview there seem to be some issues. I feel it easier to report them as a Github Issue as pictures can be included and so on.
Thanks to @aaronbell for the possibility to see the progress and comment on it.
This is a unsorted list of things I found while reviewing the
CascadiaCodeNF.ttffile. These are almost all not bugs. Just my thoughts.bookmarkslash too big
The icon is wider than one advance width and therefore this is not really the 'monospaced' variant. Codepoint is
F533, original codepoint isF306.That is in the scale group:
Lets have a look at the other 3:
Ah,
F07Bis still missing:and the filled pair seems to be good:
So maybe this is because
F07Bis still missing, or some other reason.gender circle too big
Codepoint
F22D. It should be in a scale group (if you use the same scale groups):After seeing this and the other issue above... Maybe the last icon in a scale group is always not included in the group? Just a hunch. But then the hand-symbols (see above, between the hourglasses and
TM(F255-F25B) are all nicely matching, including the last one :thinking:Caskaydia on the other hand does a not so nice job on
F246(circled pink). It fills the whole 'cell' like a powerline glyph; that is not very nice. Note to self: Check if we can do something about that.More examples where Cascadia shines and Caskaydia needs to hide ;)
Scale group synchronized shift (and not only scale)
The moon phases, patched codepoints
E38D-E3A8do not keep the center of the moon in the center. This can of course also be a design choice (I believe both have advantages and drawbacks).Here how they look like if people switch from one to another:
More on weather icons
This can all be design choices, but wanted to point out:
clouds sit on the baseline instead being centered
wind directions are centered
turning wind and other arrows are top-aligned (?!)
Thermometer scaled ridiculously big in Caskaydia, see comment already above. But that is a really hard problem when you do not know the metrics of the target font. There are some strange designs out there...
Chess pieces have a sane scale in Cascadia, but then iirc, I tried to make them smaller and then some people complained that they have a chess program and the pieces are now so small one can hardly see them, give us the bigger chess pieces back. Every change breaks someone's workflow :grimacing: But in principle I envy Cascadia here.
Bricks lost aspect ratio
It is hard(er) to recognize the click bricks (to not-mention the company that starts with L and end in EGO).
Powerline symbols
I know this is maybe too late as we already have Cascadia Code PL and changing this (if wanted at all) can break the experience for users who already use them)...
Usually "I like" to have the center of the 'cell' and with it the tip of the triangular powerline glyphs to be the middle of the ordinary capitals which usually is also the middle of square brackets etc and the same height as 'minus' and so on. At least roughly. This is not the case for Caskadia: