search

Finite-Loop-Club-NMAMIT / flc-website-legacy

Official Repository of Finite Loop Club website.
https://finiteloop.co.in
10 stars 14 forks source link

Update of social media hyperlinks in the footer required #70

Open tmsagarofficial opened 9 months ago

tmsagarofficial commented 9 months ago

I would like to point out that all the social media links such as Instagram. facebook etc.

image

when clicked upon them these links open in the same tab as the current tab. I really feel that making sure that these links open in a separate or new tab would contribute towards user experience and also maintain a good flow for the user.

Pls assign this issue to me so that I can work on the same under hacktoberfest

nagarajpandith commented 8 months ago

you can go ahead if you think inserting target="_blank" is really a valuable contribution. we will accept it. along with this, it'd be nice if you can find out and replace the usage of next/link on non-external links in this project like these social links. keep it only for the internal routes.

tmsagarofficial commented 8 months ago

@nagarajpandith Thanks for assigning will start working on it

tmsagarofficial commented 8 months ago

you can go ahead if you think inserting target="_blank" is really a valuable contribution. we will accept it. along with this, it'd be nice if you can find out and replace the usage of next/link on non-external links in this project like these social links. keep it only for the internal routes.

I didn't get this part of next/link ... can u please eloborate....

nagarajpandith commented 8 months ago

there is usage of tag for all of the links here. you need to replace them with traditional anchor tag <a> if their href points to external sites (like instagram, facebook etc.). if it's internal routing (like Home, Team, Events etc.), just keep them as it is with the <Link> tag.