FiniteSingularity / obs-advanced-masks

Advanced Masking Plugin for OBS
GNU General Public License v2.0
136 stars 7 forks source link

[BUG] - Scale settings are not saved on exit #32

Closed 1upCAD closed 10 months ago

1upCAD commented 10 months ago

Describe the bug Setting scale to less than 100% does not save on exit, reverts back to 100% on next load.

To Reproduce Steps to reproduce the behavior: Set shape to rectangle, set properties to your liking and then set the scale setting to 30% for example. Close OBS, wait a few seconds, then reload. The source should be back to 100% in scale.

Expected behavior Scale setting should remain at what it was set on exit.

Screenshots If applicable, add screenshots to help explain your problem.

Before close (source filter set at 30% scale): image

After close and reload (source filter reverts back to 100% scale): image

Environment

FiniteSingularity commented 10 months ago

Hi @1upCAD, thank you for the bug report.

I am not able to reproduce this (seems to behave as expected on my end), but this may be due to some bugfixes/updates that were included in the latest release: https://github.com/FiniteSingularity/obs-advanced-masks/releases/tag/v0.0.7a

Please download 0.0.7a, and let me know if it fixes the issue.

1upCAD commented 10 months ago

I updated to the latest version and the issue appears to still be there.

Here are my settings on a scene that includes just a camera.

Before: image

After reload: image

FiniteSingularity commented 10 months ago

Very interesting. I'm wondering if this has something to do with some early changes in variable names (I think you've been using the plugin for a few versions now?). Have you tried deleting that one filter, and re-building it. I'll try again to reproduce it tomorrow.

1upCAD commented 10 months ago

It might be a combination. I removed the old and created a brand new filter, using the settings I screenshot above. When I reloaded, the size was correct, but the Scale setting was back to 100%. If I change it to 101%, it grows right away and then changing it back to 100% is incorrect scale. So then I just put it back to 30% like I wanted.

My findings lead to it still being a plugin issue, but I can keep testing things if needed.

I can wait until your next update but please keep me posted. Thanks.

FiniteSingularity commented 10 months ago

It does sound like a plugin issue. So that I am trying to reproduce exactly what you've got, can you confirm: You've got a scene, and that scene has a single camera source. The filter is being applied to that camera source?

1upCAD commented 10 months ago

I have a scene with a single camera source, but the filter is applied to the scene, not the source. That scene is then added in other scenes.

FiniteSingularity commented 10 months ago

Thank you for the details. I'll try to replicate the issue today.