FiniteSingularity / obs-advanced-masks

Advanced Masking Plugin for OBS
GNU General Public License v2.0
146 stars 10 forks source link

[BUG] - Advanced Mask filter has strange behavior when HDR is active #51

Open JDDoesDev opened 9 months ago

JDDoesDev commented 9 months ago

Describe the bug When setting up an advanced mask filter on a source, there was strange behavior while HDR was enabled on my primary monitor. The initial scene, without the filter, looked like this: image

The preview/filter settings window showed this: image

When activating the filter to adjust the mask, the preview became brighter and the mask was not visible: image

However the actual current scene did show the correct changes: image

And moving the filter settings window to a non-HDR monitor corrected the behavior as well (note: filter size changed to better show effect): image

In addition, turning off HDR on the HDR monitor showed the expected behavior

To Reproduce Steps to reproduce the behavior:

  1. Create a scene and apply Advanced Mask filter.
  2. View settings window on a HDR monitor
  3. Apply alpha mask, shape, and adjust parameters
  4. Note that the preview does not show the changes and looks much different than expected.
  5. Turn off HDR or move window to a non-HDR monitor
  6. Note that preview in settings window is correct

Expected behavior Preview should show filters whether on an HDR or non-HDR monitor.

Screenshots Screenshots included in description.

Environment

GPU

Additional context I appreciate you