search

FiniteSingularity / obs-composite-blur

A comprehensive blur plugin for OBS that provides several different blur algorithms, and proper compositing.
GNU General Public License v2.0
382 stars 31 forks source link

[BUG] - Blur duplicating a source #13

Closed prgmitchell closed 1 year ago

prgmitchell commented 1 year ago

Describe the bug The preview for a source in it's properties looks normal but when actually looking at the OBS preview and output, there are duplicates of the source. The repro steps mention a browser source but I confirmed this to be the case on media source as well.

To Reproduce Steps to reproduce the behavior:

  1. Open OBS
  2. Add a new browser source (you can leave all the default settings)
  3. Add a composite blur filter to the browser source

Expected behavior Blur should be applied, nothing additional.

Screenshots image

Environment

Additional context https://obsproject.com/logs/mL5FXDLV1eE3p6J5

FiniteSingularity commented 1 year ago

Thanks for reporting this. The problem seems to be when a source is smaller than the entire canvas. It looks like I'm missing a gs_ortho call on the 2-pass blur filters (Gaussian and Box).

FiniteSingularity commented 1 year ago

The PR above fixed the issue. Will test it this evening and merge.

prgmitchell commented 1 year ago

@FiniteSingularity confirmed fixed, thanks!

image

FiniteSingularity commented 1 year ago

@all-contributors please add @prgmitchell for bug

allcontributors[bot] commented 1 year ago

@FiniteSingularity

I've put up a pull request to add @prgmitchell! :tada: