search

FiniteSingularity / obs-quick-access-utility

A quick access utility dock for OBS.
GNU General Public License v2.0
50 stars 4 forks source link

[BUG] - Crash when using Websocket to create/delete sources. #60

Closed reallyjesse closed 2 weeks ago

reallyjesse commented 1 month ago

Describe the bug Fatal Crash of OBS when creating sources via a websocket. It appears to work consistently with Streamer.bot while using OBS raw sub-action.

To Reproduce Steps to reproduce the behavior:

  1. Within Streamer.bot or SAMMI that can create multiple sources via OBS Raw, I created an action that will create a source, modify its settings, and then delete the source when complete. (attached screenshots of an example action) Action Steps:
  2. OBS Raw: Create Browser Source
  3. OBS Raw: Adjust Browser Position
  4. OBS Raw: Create Image Source (GIF).
  5. OBS Raw: Adjust GIF Position
  6. Set Browser Source URL
  7. Toggle Visibility for both sources
  8. Delay for length of alert
  9. OBS Raw to delete both browser and image source.

Note this doesn't happen every time, but will eventually happen. I can get it to crash if action is done in quick succession with a few second delay between alerts. Additionally, I am noticing a bit of lag from OBS when these items are being created/deleted that doesn't appear when QAU is not installed.

OBS Logs: https://obsproject.com/logs/J5qlusQxPzBHsBdP

Screenshots Examples of the OBS Raw image image image

Environment

GPU

Additional Information Uninstalled QAU and the problem is no longer happening.

FiniteSingularity commented 1 month ago

Thank you for the bug report. Which of the releases are you using? The last couple of releases had some fixes for crashes when the source list changes. If you dont have the latest, please grab it (pre-release alpha6) and see if it resolves things.

reallyjesse commented 1 month ago

Alpha6 was the version I was using

FiniteSingularity commented 1 month ago

Sounds good. I'm completely re-doing how scenes/sources are grabbed/released, so hopefully this will be fixed in the next pre-release. I'll set up a test for this, to make sure its not some strange interaction with how websockets create/destroy sources.

FiniteSingularity commented 2 weeks ago

@reallyjesse This should be fixed in the latest release (alpha 7) or greater. I set up a Streamerbot streamerbot to add 9 different sources, wait half a second, then delete them all. Ran the action 50 times, and no crash. Also had no leaks or issues on shutdown of OBS. Closing as fixed, but if you're still seeing the problem after installing the latest, please feel free to re-open with more details.