search

FiniteSingularity / obs-retro-effects

A collection of OBS filters to give your stream that retro feel.
GNU General Public License v2.0
113 stars 4 forks source link

[BUG] - Matrix Rain filter not working on macOS #18

Closed moomerman closed 6 months ago

moomerman commented 8 months ago

Describe the bug Matrix Rain filter not working on Mac0S. I have the Retro Effects plugin installed and most of the effects are working, but Matrix Rain freezes the video when selected.

To Reproduce

  1. Open the Filters
  2. Click on Retro Effects
  3. Select Matrix Rain in the Filter dropdown
  4. Video freezes
  5. Errors in the logs

Expected behavior I should see the rain effect

Logs

15:57:32.710: Error compiling shader:
15:57:32.710: ERROR: 0:94: No matching function for call to whiteNoise2D(vec2, int)
15:57:32.710: ERROR: 0:97: Use of undeclared identifier 'noise'
15:57:32.710: ERROR: 0:98: Use of undeclared identifier 'noise'
15:57:32.710: ERROR: 0:101: Use of undeclared identifier 'rain_speed'
15:57:32.710: ERROR: 0:103: Use of undeclared identifier 'rainY'
15:57:32.710: ERROR: 0:105: Use of undeclared identifier 'rainY'
15:57:32.710: ERROR: 0:124: Use of undeclared identifier 'rain'
15:57:32.710: 
15:57:32.710: 
15:57:32.710: device_pixelshader_create (GL) failed
15:57:32.710: Pass (0) <> missing pixel shader!
15:57:32.710: [obs-retro-effects] Unable to load matrix-rain.effect file.  Errors:
15:57:32.710: (null) (270, 1): Error creating shader: ERROR: 0:94: No matching function for call to whiteNoise2D(vec2, int)
15:57:32.710: ERROR: 0:97: Use of undeclared identifier 'noise'
15:57:32.710: ERROR: 0:98: Use of undeclared identifier 'noise'
15:57:32.710: ERROR: 0:101: Use of undeclared identifier 'rain_speed'
15:57:32.710: ERROR: 0:103: Use of undeclared identifier 'rainY'
15:57:32.710: ERROR: 0:105: Use of undeclared identifier 'rainY'
15:57:32.710: ERROR: 0:124: Use of undeclared identifier 'rain'
15:57:32.710: 
15:57:32.710:

Environment

GPU

FiniteSingularity commented 8 months ago

Thank you for opening the issue @moomerman.

I haven't yet had a chance to test out the matrix effect on my mac, but will be doing so soon, and will close this ticket once a PR is in that gets it up and running properly.

FiniteSingularity commented 6 months ago

This should be fixed with PR #27