search

FiniteSingularity / obs-stroke-glow-shadow

An OBS plugin to provide efficient Stroke, Glow, and Shadow effects on masked sources.
GNU General Public License v2.0
96 stars 7 forks source link

Fix crash in get_properties function #26

Closed dnaka91 closed 8 months ago

dnaka91 commented 9 months ago

Fixing a crash due to a null pointer dereference in the various get_properties functions, which can happen if another plugin tries to get the possible properties with obs_get_source_properties through the libobs API.

In addition, move several integer constants to enums and adjust the outdated version number.

FiniteSingularity commented 8 months ago

Thank you very much for the PR. I will review it today.

FiniteSingularity commented 8 months ago

This all looks great! I'm not sure what happened with the version number, as I could have sworn I updated to 1.0.1 everywhere, but apparently not! Good catch! Also, I like the use of enums- thats how I should have done things in the first place, and I should probably switch the integer defines over for the blur plugin as well.

dnaka91 commented 8 months ago

Thanks for the kind words. I was worried that my change to enums might not be welcome :sweat_smile:. Thanks for your OBS plugins, they all work nice and I really enjoy them (the most meaningful plugins for me so far).

FiniteSingularity commented 8 months ago

No problem! I'm glad you're enjoying the plug-in. And using an enum is IMO the right way to do it in this case.