search

FiniteSingularity / obs-stroke-glow-shadow

An OBS plugin to provide efficient Stroke, Glow, and Shadow effects on masked sources.
GNU General Public License v2.0
96 stars 7 forks source link

[FEATURE] - Glow should be rendered out of sources bounds #35

Open pr0pz opened 6 months ago

pr0pz commented 6 months ago

Is your feature request related to a problem? Please describe. I'm not sure if this is a bug or intentional behavoiur but it feels kind of odd, that the glow doesn't show out of the sources bound. It gets cut off.

Describe the solution you'd like I'd expect the glow to not be cut off. For now that's only possible if I'd give the png more blank space to the edges.

Describe alternatives you've considered Only considersation would be to add more blank space to the PNG to the edges.

Additional context Here's a screenshot display an image and the glow applied that gets cut off: https://imgur.com/a/E0EX1Fh

FiniteSingularity commented 6 months ago

Hi @pr0pz!

Thank you for the feature request. This is already in my queue for the next release (though I hadn't made an issue to track it, so we'll keep it here).

The issue at hand is, OBS does not let you render outside of the bounds of a source. At the time I was creating the plugin, I was unaware that I could with a filter extend the bounds of the source. In the next feature release (hopefully in the next few weeks) I plan to add an auto-padding option that would extend the source boundaries far enough to cover whatever size glow/shadow/stroke you are adding.

In the short term, there is a work around. You can add a "Crop/Pad" filter before the stroke/glow/shadow, and if you check the "relative" checkbox and add a negative value for all directions, it will extend the boundaries of the source so that the effect properly renders. (see the attached image)

image
pr0pz commented 6 months ago

Thanks for the explanation and the workaround, it works now with the crop/pad filter. WIll play around with that!