FiniteSingularity / obs-stroke-glow-shadow

An OBS plugin to provide efficient Stroke, Glow, and Shadow effects on masked sources.
GNU General Public License v2.0
96 stars 7 forks source link

[BUG] - Stroke on adv.Mask Source alpha issue #40

Open andi242 opened 3 months ago

andi242 commented 3 months ago

Describe the bug I have a color source with advanced Mask filter on it. the color source has some alpha in it. When I add the stroke filter to the source the alpha is sort of overwritten by the color of the stroke.

To Reproduce Steps to reproduce the behavior:

  1. create color source and set alpha to lower than 255 (for testing I did 120)
  2. add adv. mask (any shape)
  3. add stroke filter (order after adv. mask)
  4. switch between stroke offset 0 and 1 to see effect
  5. optional: add a second item behind color source to check on alpha (I added a text source)

Expected behavior alpha should be applied to the color source regardless of stroke offset. Inner stroke applies alpha, but overwrites color completely

Screenshots grafik grafik grafik grafik

Environment

GPU

Additional context Haven't found a similar issue, but could be related to https://github.com/FiniteSingularity/obs-stroke-glow-shadow/issues/36

FiniteSingularity commented 3 months ago

Thanks for the bug report Andi. I’ll take a look in the next day or two.

FiniteSingularity commented 3 months ago

Hi @andi242,

Now that I've had a chance to look at this- it is a known bug in the older rendering pipeline that SGS still uses. I originally found it (and fixed it) in the Advanced Masks plug-in. In the next week or two, I'll be working on updating the rendering pipeline for SGS, as it will fix this and a couple other bugs that have been reported.

andi242 commented 3 months ago

Hi @FiniteSingularity thanks for looking into this!

shall I close the issue, since this is already adressed?

FiniteSingularity commented 3 months ago

No- let’s leave it open for others to see/find, until I fix it.