search

FiniteVolumeTransportPhenomena / PyFVTool

Finite volume toolbox in Python
GNU Lesser General Public License v2.1
13 stars 4 forks source link

Remove unused mesh dimension index property #11

Closed mhvwerts closed 1 year ago

mhvwerts commented 1 year ago

Upon extensively searching the entire repository, the .dimension property of MeshStructure and its subclasses is never used in the rest of the code.

This (unreliable floating-point) mesh geometry identifier is a legacy from the original PVTool, and has become redundant, since in PyFVTool the mesh geometry is directly inferred from the subclass type.

I hope that you agree that your code looks even better without this floating-point dimension thing!

P.S. I also propose to use super() to invoke parent classes.

P.P.S. I tested using fvtool_test.py and the Notebooks and worked fine. Set up more extensive testing in the future.

simulkade commented 1 year ago

100% agreed! In fact, I had your comment in mind while designing the new classes for different mesh types.