Upon extensively searching the entire repository, the .dimension property of MeshStructure and its subclasses is never used in the rest of the code.
This (unreliable floating-point) mesh geometry identifier is a legacy from the original PVTool, and has become redundant, since in PyFVTool the mesh geometry is directly inferred from the subclass type.
I hope that you agree that your code looks even better without this floating-point dimension thing!
P.S. I also propose to use super() to invoke parent classes.
P.P.S. I tested using fvtool_test.py and the Notebooks and worked fine. Set up more extensive testing in the future.
Upon extensively searching the entire repository, the
.dimension
property ofMeshStructure
and its subclasses is never used in the rest of the code.This (unreliable floating-point) mesh geometry identifier is a legacy from the original PVTool, and has become redundant, since in PyFVTool the mesh geometry is directly inferred from the subclass type.
I hope that you agree that your code looks even better without this floating-point
dimension
thing!P.S. I also propose to use
super()
to invoke parent classes.P.P.S. I tested using
fvtool_test.py
and the Notebooks and worked fine. Set up more extensive testing in the future.