search

FiniteVolumeTransportPhenomena / PyFVTool

Finite volume toolbox in Python
GNU Lesser General Public License v2.1
18 stars 4 forks source link

pyfvtool module import standardization #29

Closed mhvwerts closed 9 months ago

mhvwerts commented 9 months ago

This pull request fixes a number of "star imports" and standardizes the way PyFVTool is imported in user scripts.

This is only a partial response to #27 , addressing the user scripts. However, the pyfvtool module itself also contains some star imports. These are likely easily fixed, but that will have to wait until some next time.

This version passes all pytest tests (coverage has been increased slightly).

mhvwerts commented 9 months ago

I may be able to take care also of the star imports inside the pyfvtool module. So I keep this a draft PR and push any successful attempts.

mhvwerts commented 9 months ago

Please also check line 319 in cell.py. I added a return statement that seemed to be missing.

mhvwerts commented 9 months ago

All star imports fixed, and all tests still working. Closes #27

simulkade commented 9 months ago

Fantastic work @mhvwerts !