search

Finschia / cometbft

CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine
https://docs.cometbft.com
Apache License 2.0
0 stars 0 forks source link

Return error when AddChannel fails (Triage on ostracon#500) #13

Open 0Tech opened 1 year ago

0Tech commented 1 year ago

The subject of the triage:

Mdaiki0730 commented 1 year ago

It seems that it is not applied as of v0.38.0. By reflecting this PR, you can add proper error handling. https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/transport.go#L272-L279

In particular, it is not specified why error is no longer returned as a return value. https://github.com/tendermint/tendermint/pull/6339/commits/03393fb6ec801203d6742a37fa442fe3a05e7633

Mdaiki0730 commented 12 months ago

Additional discussion is required.