Fix code duplication in the newHash (Triage on ostracon#509)

Finschia / cometbft

CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine

https://docs.cometbft.com

Apache License 2.0

0 stars 0 forks source link

Closed 0Tech closed 11 months ago

0Tech commented 11 months ago

The subject of the triage:

Mdaiki0730 commented 11 months ago

As of v0.38.0, there is no function with the same name, but there is a function that seems to be an alternative. https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/pex/addrbook.go#L112-L119

This seems to have been fixed by tendermint#9445 to improve performance. The code written in crypto.CRandBytes has been modified to be reused. https://github.com/tendermint/tendermint/pull/9445

It seems that there is no need to reflect it in cometbft.