search

Finschia / cometbft

CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine
https://docs.cometbft.com
Apache License 2.0
0 stars 0 forks source link

Fix the thread-unsafe of PeerState logging #7

Open 0Tech opened 11 months ago

tkxkd0159 commented 11 months ago

This PR makes sense to prevent potential thread-unsafe situation. But we need to consider if we really don't need to log PeerState value. If it's necessary, we need to implement extra logic instead of removing it when we make a PR at the upstream. (e.g. Logging in PickVoteToSend instead of PickSendVote)

tkxkd0159 commented 10 months ago

@tnasu said that it wasn’t worth it when PickSendVote was called with the logging. Because of the logging too much. It cannot help us under the high-traffic network. So he decided to discard it.