Avoid panic when addr does not exist in book (Triage on ostracon#484)

Finschia / cometbft

CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine

https://docs.cometbft.com

Apache License 2.0

0 stars 0 forks source link

Open 0Tech opened 10 months ago

0Tech commented 10 months ago

The subject of the triage:

0Tech commented 10 months ago

In the current implementation of cometbft, the function is not in use.

Mdaiki0730 commented 10 months ago

It seems that it is not applied as of v0.38.0. I think it's better to send a PR upstream because you can add proper error handling. https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/pex/addrbook.go#L237

Mdaiki0730 commented 10 months ago

We plan to submit a PR to cometbft regarding this issue.