Optimization of function signChallenge() (Triage on ostracon#485)

Finschia / cometbft

CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine

https://docs.cometbft.com

Apache License 2.0

0 stars 0 forks source link

Open 0Tech opened 11 months ago

0Tech commented 11 months ago

The subject of the triage:

Mdaiki0730 commented 11 months ago

It seems that it is not applied as of v0.38.0. I think it's better to send the PR upstream because it reduces unnecessary writing. https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/conn/secret_connection.go#L389-L395

Mdaiki0730 commented 11 months ago

We plan to submit a PR to cometbft regarding this issue.