search

Finschia / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
0 stars 0 forks source link

Triage finschia-sdk#291 #32

Open 0Tech opened 9 months ago

0Tech commented 9 months ago

The subject of the triage:

0Tech commented 9 months ago

It's still an issue even for the upstream (cosmos/cosmos-sdk#15626). We can submit a PR onto cosmos/cosmos-sdk. The long term solution is under discussion on cometbft/cometbft. However, I don't see a critical use case of GetBlockByHash(). The change on GetTxsEventRequest is not in backward compatible way, so if we want to adopt it, we must mind the field numbers. The PR says the modification was due to the performance, so we must make sure our client relies on this API.