Triage finschia-sdk#883

Finschia / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

0 stars 0 forks source link

Triage finschia-sdk#883 #77

Closed 0Tech closed 4 months ago

0Tech commented 6 months ago

The subject of the triage:

Finschia/finschia-sdk#883

170210 commented 5 months ago

This PR can be abandoned. Because cosmos-sdk has already used zerolog in cosmos.io/log. Related PRs:

cosmos/cosmos-sdk#14967
cosmos/cosmos-sdk#15011

But if necessary, we may need to make a PR to finschia/cosmos-sdk with following configuration. (It decided by finschia/cometbft)

    FlagLogPath       = "log_path"
    FlagLogMaxAge     = "log_max_age"
    FlagLogMaxSize    = "log_max_size"
    FlagLogMaxBackups = "log_max_backups"

170210 commented 4 months ago

update: https://github.com/Finschia/ostracon/pull/535 has been abandoned by https://github.com/Finschia/cometbft/issues/17, this PR also can be abandoned.