feat: merge 0.14.0 - Githubissues

Finschia / cosmwasm

Fast and reusable WebAssembly smart contract runtime(and library) for finschia-sdk.

Apache License 2.0

27 stars 14 forks source link

feat: merge 0.14.0 #122

Closed shiki-tak closed 3 years ago

shiki-tak commented 3 years ago

Closes: #121

Description

Motivation and context

How has this been tested?

Checklist:

[ ] I followed the contributing guidelines.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

brew0722 commented 3 years ago

We decided not to use the develop branch, so I think we need to change the target to the main branch. Others are LGTM.

whylee259 commented 3 years ago

In packages/vm/src/testing/mock.rs, The upstream has removed canonicalize_cost and humanize_cost from MockApi, but the merge results leave them as before. Is it intended?

shiki-tak commented 3 years ago

In packages/vm/src/testing/mock.rs, The upstream has removed canonicalize_cost and humanize_cost from MockApi, but the merge results leave them as before. Is it intended?

You mean this? https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dR127

The upstream MockApi uses GAS_COST_CANONICALIZE as a constant, but since we added the following test, we left it as the test fails with a constant. https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dR265

whylee259 commented 3 years ago

minor

https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dL52-L58 The deprecated initializer can be removed.