Finschia / cosmwasm

Fast and reusable WebAssembly smart contract runtime(and library) for finschia-sdk.

Apache License 2.0

27 stars 14 forks source link

fix: modify the chglog template to filter commits and correct PRs' URL #170

Closed loloicci closed 2 years ago

loloicci commented 2 years ago

Description

This PR modifies chaglog template to

filter commits that are not generated with "squash and merge" merging
correct generating URLs for PR from https://.../issues/XXX to https://.../pull/XXX in the suffix of PRs' title

And, modify to print a note to devtools/update_changelog.sh

Closes #164

Types of changes

[ ] Bug fix (changes which fixes an issue)
[ ] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes. (Not Needed)
[x] The PR title and commits are followed conventional commit form.

zemyblue commented 2 years ago

@loloicci , can this script distinguish between fixing bugs or adding features and then reflect them in the changes?

loloicci commented 2 years ago

@zemyblue yes, but not literally. This script decides it is a PR number if the tail of the commit is (#XXX). This is the default subject of the squash and merge commit. Other numbers are still linked as issues.

zemyblue commented 2 years ago

@zemyblue yes, but not literally. This script decides it is a PR number if the tail of the commit is (#XXX). This is the default subject of the squash and merge commit. Other numbers are still linked as issues.

I meant that this script would automatically generate a change log, but it doesn't seem to distinguish between Features or Fixes or Changes sections. You need to further change the PR section to which section it belongs. Is it right?

loloicci commented 2 years ago

@zemyblue In my local, these three types of changes are distinguished. Can you try to remove some recent tags (e.g. v0.16.3-0.5-0 and v0.16.3-0.5.1) and retry to execute update_changelog.sh? If three types of PRs are not distinguished, tell me the output.

zemyblue commented 2 years ago

Oh, it works well.

But my system is Apple M1 Pro, so I need to change docker run part like below in the generate_chagnelog.sh. Please check it works well in other system.

MD="docker run --platform linux/x86_64 -v $(pwd):/workdir quay.io/git-chglog/git-chglog"

loloicci commented 2 years ago

Oh, it works well.

But my system is Apple M1 Pro, so I need to change docker run part like below in the generate_chagnelog.sh. Please check it works well in other system.

MD="docker run --platform linux/x86_64 -v $(pwd):/workdir quay.io/git-chglog/git-chglog"

It works in non M1 mac. I deal with it in another issue.