Finschia / cosmwasm

Fast and reusable WebAssembly smart contract runtime(and library) for finschia-sdk.
Apache License 2.0
27 stars 14 forks source link

feat: force the dynamic linked functions' module name to start with "dynamiclinked_" #248

Closed loloicci closed 2 years ago

loloicci commented 2 years ago

Description

Before this PR, importing modules like WASI API cannot be detected in the dynamiclink branch. This is because all importing is treated as dynamic link functions' import. We want to detect imports other than dynamic link functions and issue an error. This PR changes the rule of the dynamic linked function's module name and forces them to start with "dynamiclinked".

solves #243

These tests are done in https://github.com/line/lbm-sdk/pull/760 depending https://github.com/line/wasmvm/pull/78

Types of changes

Checklist

loloicci commented 2 years ago

I thought it could be dynamic_linked since the other parts are basically dynamic_link, but LGTM

The name "dynamiclinked_" is intended to emphasize it is a prefix. So, I will merge it without changing it. Thank you.