Finschia / cosmwasm

Fast and reusable WebAssembly smart contract runtime(and library) for finschia-sdk.

Apache License 2.0

27 stars 14 forks source link

feat: switch how to do dynamic link and validate interface to solve rust/Go pointer sharing issue #283

Closed loloicci closed 1 year ago

loloicci commented 1 year ago

Description

This PR is a part of #273 and switches how to do dynamic link and validate interfaces for other contracts. After merging this, the GetContractEnv and the GetWasmerModule APIs will not be used in the wasm module. This PR also improves some contracts used by integration tests.

Types of changes

[x] Bug fix (changes which fixes an issue)
[ ] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] The PR title and commits are followed conventional commit form.

da1suk8 commented 1 year ago

@loloicci

I think it is better to remove the native_dynamic_link_trampoline_works() test as well. It is not very clear why there is only this test.