Finschia / cosmy-wasmy

wibbly wobbly cosmy wasmy tool to interact with cosmwasm contracts
https://marketplace.visualstudio.com/items?itemName=spoorthi.cosmy-wasmy
GNU General Public License v3.0
0 stars 0 forks source link

revert #16 #18

Open ulbqb opened 10 months ago

ulbqb commented 10 months ago

https://github.com/Finschia/cosmy-wasmy/blob/63600a9af71aea421295b2301206216e2b25ef86/src/helpers/sign/wrapwallet.ts#L7

It is enough to use cosmjs/crypto@0.28.4.

170210 commented 10 months ago

@ulbqb Yes, but since cosmy-wasmy is already using @cosmjs/amino, which contains cosmjs/crypto, it will trigger a warning if not modified.

ulbqb commented 10 months ago

The cause of the warning is to use different versions between our @cosmjs/crypto and @cosmjs/amino's one.

import { HdPath,Slip10RawIndex } from "@cosmjs/amino/node_modules/@cosmjs/crypto"; 

I don't think this is correct usage of package. It is strange to use packages in imported package's node_modules.