(code-hygiene) Use the constants - Githubissues

Finschia / finschia-js

finschia-js is javascript sdk for Finschia

Apache License 2.0

7 stars 4 forks source link

(code-hygiene) Use the constants #72

Open 0Tech opened 1 year ago

0Tech commented 1 year ago

          Please use the corresponding constant.

    amount: coins(250000, simapp.denomFee),

It would be nice to create an issue on it.

_Originally posted by @0Tech in https://github.com/line/lbmjs/pull/71#discussion_r1106791300_

The following magic strings should be replaced. It's not exhaustive.

"cony" -> simapp.denomFee
"stake" -> simapp.denomStake
"link" -> simapp.prefix