Finschia / finschia-js

finschia-js is javascript sdk for Finschia
Apache License 2.0
7 stars 4 forks source link

Implement and test MsgStoreCode.instantiate_permission(AccessType) #74

Closed jaeseung-bae closed 1 year ago

jaeseung-bae commented 1 year ago

This unimplemented issue is still TODO status in upstream. To use AccessType for MsgStoreCode, we need to implement and contribute to upstream as well.

loin3 commented 1 year ago

amino name of each AccessType enum is Nobody, EveryBody, OnlyAddress. They don't work as other enum such as VoteOption in gov module. Because AccessType does not use gogoproto_enum_stringer in proto file, so AccessType implements its own String() method.

I got a clue from dec coin comment

So, instantiate_permission in amino convertor should convert proto msg to amino msg like below.

instantiate_permission: {
  permission: "OnlyAddress",
  address: "link146asaycmtydq45kxc8evntqfgepagygelel00h"
}
or
instantiate_permission: {
  permission: "Nobody",
  address: ""
}
or
instantiate_permission: {
  permission: "Everybody",
  address: ""
}